| Summary: | [Qt] canvas clipping is buggy | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Major | CC: | ariya.hidayat, benjamin, commit-queue, cshu, hausmann, laszlo.gombos, noam | ||||
| Priority: | P2 | Keywords: | Qt | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Noam Rosenthal
2009-12-10 20:11:02 PST
Confirmed. Here is the direct link to the test : http://glimr.rubyforge.org/cake/canvas.html#KeyboardTest The image should not be clipped when transformed. Created attachment 48713 [details]
Fix GraphicsContext::roundToDevicePixels in Qt
I found the source of the problem - our GraphicsContext::roundToDevicePixels function is wrong, as it doesn't make the right calculation in the case of rotating images.
The attached fix makes that function completely equivalent to the CG implementation, and rotating canvas images now look fine!
Nice! I've seen this bug a few times in the past. Any chance that this is also covered by an existing but currently skipped canvas layout test? Adding Ariya to CC, he's more qualified than me to review this piece :) Comment on attachment 48713 [details]
Fix GraphicsContext::roundToDevicePixels in Qt
Looks good.
Comment on attachment 48713 [details] Fix GraphicsContext::roundToDevicePixels in Qt Clearing flags on attachment: 48713 Committed r54811: <http://trac.webkit.org/changeset/54811> All reviewed patches have been landed. Closing bug. |