| Summary: | Accelerated transitions broken when mixed with paused animations | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cmarrin, dino, ml, webkit.review.bot | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
Created attachment 44638 [details]
Patch
style-queue ran check-webkit-style on attachment 44638 [details] without any errors.
Comment on attachment 44638 [details] Patch > m_startTime = param; > - > + > // Decide whether to go into looping or ending state Extra whitespace added there. > -void KeyframeAnimation::endAnimation(bool reset) > +void KeyframeAnimation::pauseAnimation(double timeOffset) > { > - if (m_object) { > + if (!m_object) > + return; > + > + fprintf(stderr, "pausing animation, offset %f\n", timeOffset); Please remove the fprintf. > + struct AnimationProcessingInfo { > + AnimationProcessingInfo(AnimationProcessingAction action = Remove, double timeOffset = 0) > + : action(action) > + , timeOffset(timeOffset) { } The braces should go each on its own separate line: { } Perhaps the struct should be called AnimationProcessingAction and the enum renamed to something else? Perhaps not. |
Created attachment 44630 [details] Testcase The attached testcase shows a problem where paused animations interfere with hardware transitions. When you load the testcase, the outer box should animate left, animate right, then animate left again. The bug is that the last animation fails; it jumps left at the end.