Bug 32387 – Accelerated transitions broken when mixed with paused animations

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Created attachment 44630 [details]
Testcase

The attached testcase shows a problem where paused animations interfere with hardware transitions.

When you load the testcase, the outer box should animate left, animate right, then animate left again. The bug is that the last animation fails; it jumps left at the end.

[Simon Fraser (smfr)]

Created attachment 44638 [details]
Patch

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44638 [details] without any errors.

[Simon Fraser (smfr)]

<rdar://problem/7443031>

Comment on attachment 44638 [details]
Patch

>                      m_startTime = param;
> -
> +                
>                  // Decide whether to go into looping or ending state

Extra whitespace added there.

> -void KeyframeAnimation::endAnimation(bool reset)
> +void KeyframeAnimation::pauseAnimation(double timeOffset)
>  {
> -    if (m_object) {
> +    if (!m_object)
> +        return;
> +
> +    fprintf(stderr, "pausing animation, offset %f\n", timeOffset);

Please remove the fprintf.

> +    struct AnimationProcessingInfo {
> +        AnimationProcessingInfo(AnimationProcessingAction action = Remove, double timeOffset = 0)
> +            : action(action)
> +            , timeOffset(timeOffset) { }

The braces should go each on its own separate line:
           {
           }

Perhaps the struct should be called AnimationProcessingAction and the enum renamed to something else? Perhaps not.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/52017