Summary: | Add a manual test for crash in DOMWindow::clearTimeout when DOMWindow is not connected to frame | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dmitry Titov <dimich> | ||||
Component: | Tools / Tests | Assignee: | Dmitry Titov <dimich> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Dmitry Titov
2009-12-09 16:25:45 PST
Created attachment 44583 [details]
Proposed patch.
style-queue ran check-webkit-style on attachment 44583 [details] without any errors.
Comment on attachment 44583 [details]
Proposed patch.
r=me
I don't quite understand why this needs to take ~10 seconds (what's back/forward cache expiration?), but maybe a new DRT method can make this instant? (In reply to comment #4) > I don't quite understand why this needs to take ~10 seconds (what's > back/forward cache expiration?), but maybe a new DRT method can make this > instant? Indeed, there is no way today to cause immediate b/f cache expiration so the destruction of the cached pages can not be realistically tested in DRT today. I thought about something like layoutTestController.setBackForwardCacheExpiration(seconds) but wasn't sure the single test justifies it... Perhaps we should do it next time we have a need? This case seems significant enough to warrant adding a DRT method. Perhaps it would be easier to just force immediate expiration, rather than set a timeout? (In reply to comment #6) > This case seems significant enough to warrant adding a DRT method. > > Perhaps it would be easier to just force immediate expiration, rather than set > a timeout? Ok. I'll take a look at adding a method. Will delay landing the patch until implementation is ready, then we'll decide. Ping? Curious what the status is here. This patch has been approved for landing for a little over 2 weeks. Ping? I agree with Alexey that having manual test is somewhat useless since nobody ever runs them. I have this task (make it possibel to test the bf cache expiration from DRT in my list and will get to it at some point, in a few weeks. So for now I guess I'll commit this test so it is there, but will address the DRT testing at some point. |