Bug 32338

Summary: [Chromium] webkit.org Chromium builder by missing GeolocationServiceChromium
Product: WebKit Reporter: Jonathan Dixon <joth>
Component: WebKit Misc.Assignee: Jonathan Dixon <joth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch 1
none
Patch 2. Include ChangeLog this time dglazkov: review+, commit-queue: commit-queue-

Description Jonathan Dixon 2009-12-09 12:15:44 PST
There is currently a build error in the Chromium Mac Release build bot.
http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/481/steps/compile-webkit/logs/stdio

Undefined symbols:
  "WebCore::GeolocationService::s_factoryFunction", referenced from:
      __ZN7WebCore18GeolocationService17s_factoryFunctionE$non_lazy_ptr in libwebcore.a(GeolocationService.o)
ld: symbol(s) not found
collect2: ld returned 1 exit status

PhaseScriptExecution /Users/joth/dev/chromium_git/src/third_party/WebKit/WebKit/chromium/./xcodebuild/WebKit.build/Debug/webkit.build/Script-676D4CE01E3365CE0B035461.sh
    cd /Users/joth/dev/chromium_git/src/third_party/WebKit/WebKit/chromium
    /bin/sh -c /Users/joth/dev/chromium_git/src/third_party/WebKit/WebKit/chromium/./xcodebuild/WebKit.build/Debug/webkit.build/Script-676D4CE01E3365CE0B035461.sh
** BUILD FAILED **

The following build
Comment 1 Jonathan Dixon 2009-12-09 12:17:18 PST
Created attachment 44553 [details]
Patch 1
Comment 2 WebKit Review Bot 2009-12-09 12:19:09 PST
style-queue ran check-webkit-style on attachment 44553 [details] without any errors.
Comment 3 Jonathan Dixon 2009-12-09 12:27:52 PST
Created attachment 44556 [details]
Patch 2. Include ChangeLog this time
Comment 4 WebKit Review Bot 2009-12-09 12:30:08 PST
style-queue ran check-webkit-style on attachment 44556 [details] without any errors.
Comment 5 Dimitri Glazkov (Google) 2009-12-09 12:31:58 PST
Comment on attachment 44556 [details]
Patch 2. Include ChangeLog this time

ok
Comment 6 WebKit Commit Bot 2009-12-09 12:44:46 PST
Comment on attachment 44556 [details]
Patch 2. Include ChangeLog this time

Rejecting patch 44556 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
..
	M	WebCore/ChangeLog
	M	WebCore/WebCore.gypi
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following files contain tab characters:

        trunk/WebCore/ChangeLog

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
 at /usr/local/git/libexec/git-core/git-svn line 558
Comment 7 Steve Block 2009-12-09 14:36:44 PST
(In reply to comment #6)
> (From update of attachment 44556 [details])
> Rejecting patch 44556 from commit-queue.

Fixed tab and landed manually as http://trac.webkit.org/changeset/51925