Summary: | Web Inspector: Get rid of synchrnonous debuggerEnabled, profilerEnabled calls. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bweinstein, eric, joepeck, rik, timothy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Feldman
2009-12-09 10:56:08 PST
Created attachment 44547 [details]
[PATCH] Proposed change.
Ping? Looks like this has been r+'d for about 2 weeks now. I assume folks are just busy with the holidays? Comment on attachment 44547 [details]
[PATCH] Proposed change.
Things got changed a bit, so I'll need to do some merging. Clearing the flag for now.
While making this change I thought that maybe single place for storing settings should reside in backend, not the frontend, so I did not land it and refactored settings instead. Now it is time to revisit it. Goal is still the same, no sync operations between the backend and fronend. Created attachment 49881 [details]
[PATCH] Proposed change.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorBackend.cpp M WebCore/inspector/InspectorBackend.h M WebCore/inspector/InspectorBackend.idl M WebCore/inspector/InspectorController.cpp M WebCore/inspector/front-end/BreakpointsSidebarPane.js M WebCore/inspector/front-end/ProfilesPanel.js M WebCore/inspector/front-end/ScriptsPanel.js M WebCore/inspector/front-end/Settings.js M WebCore/inspector/front-end/inspector.js M WebKit/chromium/src/js/DevTools.js Committed r55464 |