Summary: | [V8] Isolated world reuse failure | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Søren Gjesse <sgjesse> | ||||||
Component: | WebCore Misc. | Assignee: | Søren Gjesse <sgjesse> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, ager, commit-queue, dglazkov, eric, pfeldman, sgjesse, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Søren Gjesse
2009-12-08 23:56:36 PST
Created attachment 44529 [details]
Patch
Attachment 44529 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/V8Proxy.cpp:396: One line control clauses should not use braces. [whitespace/braces] [4]
WebCore/bindings/v8/V8Proxy.cpp:398: One line control clauses should not use braces. [whitespace/braces] [4]
WebCore/bindings/v8/V8Proxy.cpp:1383: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WebCore/bindings/v8/V8Proxy.cpp:1383: Use 0 instead of NULL. [readability/null] [5]
WebCore/bindings/v8/V8Proxy.cpp:1384: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 5
Comment on attachment 44529 [details] Patch > + if (debugId == -1) { > + snprintf(buffer, sizeof(buffer), "injected"); > + } else { > + snprintf(buffer, sizeof(buffer), "injected,%d", debugId); > + } no {} for single line bodies > targetContext->SetData(v8::String::New(buffer)); > > return true; > @@ -1378,6 +1380,8 @@ int V8Proxy::contextDebugId(v8::Handle<v > return -1; > v8::String::AsciiValue ascii(context->GetData()); > char* comma = strnstr(*ascii, ",", ascii.length()); > + if (comma == NULL) > + return NULL; if (!comma) return 0; > return atoi(comma + 1); > } > Created attachment 44530 [details]
Patch fixing webkit style
Comment on attachment 44530 [details]
Patch fixing webkit style
Rejecting patch 44530 from commit-queue.
Unexpected failure when landing patch! Please file a bug against bugzilla-tool.
Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44530']" exit_code: 1
Last 500 characters of output:
nd_handle_errors
self.run()
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 54, in run
self.clean()
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in clean
step.run()
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/buildsteps.py", line 101, in run
os.chdir(self._tool._scm.checkout_root)
AttributeError: 'NoneType' object has no attribute 'checkout_root'
Comment on attachment 44530 [details]
Patch fixing webkit style
Let's try again?
Comment on attachment 44530 [details]
Patch fixing webkit style
Rejecting patch 44530 from commit-queue.
Unexpected failure when landing patch! Please file a bug against bugzilla-tool.
Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44530']" exit_code: 1
Last 500 characters of output:
nd_handle_errors
self.run()
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 54, in run
self.clean()
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in clean
step.run()
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/buildsteps.py", line 101, in run
os.chdir(self._tool._scm.checkout_root)
AttributeError: 'NoneType' object has no attribute 'checkout_root'
This is from Adam's refactoring of the queues last night. I'll stop the commit-queue and we'll get a fix in shortly. Comment on attachment 44530 [details]
Patch fixing webkit style
Sorry for the noise. Adam believes to have fixed the issue. I've restarted the commit bot.
Comment on attachment 44530 [details] Patch fixing webkit style Clearing flags on attachment: 44530 Committed r51912: <http://trac.webkit.org/changeset/51912> All reviewed patches have been landed. Closing bug. |