Bug 32273

Summary: add ANDROID to STORE_FONT_CUSTOM_PLATFORM_DATA
Product: WebKit Reporter: Mike Reed <mikerreed>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, commit-queue, jorlow, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
this fixes the issue, by adding PLATFORM(ANDROID) to the check in CachedFont.cpp
none
add PLATFORM(ANDROID)
none
Patch none

Mike Reed
Reported 2009-12-08 05:08:06 PST
ANDROID can support STORE_FONT_CUSTOM_PLATFORM_DATA, so I am adding its platform to the list at the head of CachedFont.cpp
Attachments
this fixes the issue, by adding PLATFORM(ANDROID) to the check in CachedFont.cpp (651 bytes, patch)
2009-12-11 07:54 PST, Mike Reed 		no flags
DetailsFormatted DiffDiff
add PLATFORM(ANDROID) (1.27 KB, patch)
2009-12-11 09:37 PST, Mike Reed 		no flags
DetailsFormatted DiffDiff
Patch (1.21 KB, patch)
2010-07-08 02:54 PDT, Steve Block 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mike Reed
Comment 1 2009-12-11 07:54:03 PST
Created attachment 44689 [details] this fixes the issue, by adding PLATFORM(ANDROID) to the check in CachedFont.cpp
WebKit Review Bot
Comment 2 2009-12-11 07:56:02 PST
style-queue ran check-webkit-style on attachment 44689 [details] without any errors.
Darin Adler
Comment 3 2009-12-11 08:12:58 PST
Comment on attachment 44689 [details] this fixes the issue, by adding PLATFORM(ANDROID) to the check in CachedFont.cpp Change is fine. Can't land without a change log, though, so review-.
Mike Reed
Comment 4 2009-12-11 09:37:54 PST
Created attachment 44692 [details] add PLATFORM(ANDROID) same as previous patch, but this one includes the ChangeLog
Alexey Proskuryakov
Comment 5 2010-06-12 15:51:39 PDT
This patch has been overlooked, because it isn't marked for review. Please see <http://webkit.org/coding/contributing.html> for more information.
Steve Block
Comment 6 2010-07-08 02:54:19 PDT
Created attachment 60860 [details] Patch
Steve Block
Comment 7 2010-07-08 02:55:21 PDT
Taking over this patch from Mike.
Jeremy Orlow
Comment 8 2010-07-12 07:47:25 PDT
Comment on attachment 60860 [details] Patch r=me
WebKit Commit Bot
Comment 9 2010-07-12 08:06:46 PDT
Comment on attachment 60860 [details] Patch Clearing flags on attachment: 60860 Committed r63088: <http://trac.webkit.org/changeset/63088>
WebKit Commit Bot
Comment 10 2010-07-12 08:06:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.