Bug 32251

Summary:

To avoid potential crash in Android history item

Product:

WebKit

Reporter:

Grace Kloba <klobag>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

android-webkit-unforking, beidson, benm, commit-queue, darin, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Android

OS:

Android

Attachments:

Description	Flags
proposed patch	eric: review-
new patch according to the comment.	darin: review+, commit-queue: commit-queue-

Grace Kloba

Reported 2009-12-07 15:13:03 PST

As AndroidWebHistoryBridge holds a dumb pointer of HistoryItem and HistoryItem holds a RefPtr of AndroidWebHistoryBridge, the dumb pointer needs to be cleared when HistoryItem is deleted to avoid potential crash.

Attachments
proposed patch (2.56 KB, patch) 2009-12-07 15:16 PST, Grace Kloba	eric: review-	Details Formatted Diff Diff
new patch according to the comment. (2.66 KB, patch) 2009-12-07 16:53 PST, Grace Kloba	darin: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Grace Kloba

Comment 1 2009-12-07 15:16:10 PST

Created attachment 44436 [details] proposed patch

Eric Seidel (no email)

Comment 2 2009-12-07 16:44:27 PST

Comment on attachment 44436 [details] proposed patch The tab in AndroidWebHistoryBridge.h will prevent this from being landed as is. Although WebKit has no explicit wrapping rule, it mgiht make sense to wrap the txt in the ChangeLog at some point. It feels strange that HistoryItem.cpp has to have an ANDROID ifdef, but maybe that's the design that you and Brady agreed on? r- for the tab.

Grace Kloba

Comment 3 2009-12-07 16:53:31 PST

Created attachment 44448 [details] new patch according to the comment. Fix the tab. Add line break in the ChangeLog. The pattern used in HistoryItem is following the existing model.

WebKit Commit Bot

Comment 4 2009-12-11 02:24:00 PST

Comment on attachment 44448 [details] new patch according to the comment. Rejecting patch 44448 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Adler', '--force']" exit_code: 1 patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/history/HistoryItem.cpp Hunk #1 FAILED at 102. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/history/HistoryItem.cpp.rej patching file WebCore/history/android/AndroidWebHistoryBridge.h

Ben Murdoch

Comment 5 2009-12-11 02:38:07 PST

This is a straightforward merge fix, I'll land manually.

Ben Murdoch

Comment 6 2009-12-11 04:21:49 PST

Landed as r51980.

Note You need to log in before you can comment on or make changes to this bug.