Summary: | Rename dom/ClassNames.{cpp,h} | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nate Chapin <japhet> | ||||
Component: | WebCore Misc. | Assignee: | Nate Chapin <japhet> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, michelangelo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Nate Chapin
2009-12-07 15:06:35 PST
Probably best to e-mail webkit-dev for more people to see the question. Created attachment 44482 [details]
Rename ClassNames to SpaceSplitString
I think I correctly modified all the build files, but is there a preferred way to confirm that?
Comment on attachment 44482 [details] Rename ClassNames to SpaceSplitString > -__ZN7WebCore14ClassNamesData12createVectorEv > +__ZN7WebCore14SpaceSplitStringData12createVectorEv > -__ZN7WebCore14ClassNamesData11containsAllERS0_ > +__ZN7WebCore14SpaceSplitStringData11containsAllERS0_ These changes are incorrect. The "14" is the length of the string "ClassNamesData", so it should be "20" instead. But really this file should not be updated. There's no way for the "average person" to generate this. It has to be generated by running the framework in a test environment. Stephanie Lewis normally does it. > Index: WebCore/html/HTMLAnchorElement.cpp > =================================================================== > --- WebCore/html/HTMLAnchorElement.cpp (revision 51859) > +++ WebCore/html/HTMLAnchorElement.cpp (working copy) > @@ -36,6 +36,7 @@ > #include "Page.h" > #include "RenderImage.h" > #include "Settings.h" > +#include "SpaceSplitString.h" I don't understand how the name change triggered the need for an additional include. I'm going to say r=me but I think both of those are errors. The build file changes look right to me. (In reply to comment #3) > (From update of attachment 44482 [details]) > > -__ZN7WebCore14ClassNamesData12createVectorEv > > +__ZN7WebCore14SpaceSplitStringData12createVectorEv > > > -__ZN7WebCore14ClassNamesData11containsAllERS0_ > > +__ZN7WebCore14SpaceSplitStringData11containsAllERS0_ > > These changes are incorrect. The "14" is the length of the string > "ClassNamesData", so it should be "20" instead. But really this file should not > be updated. There's no way for the "average person" to generate this. It has to > be generated by running the framework in a test environment. Stephanie Lewis > normally does it. > > > Index: WebCore/html/HTMLAnchorElement.cpp > > =================================================================== > > --- WebCore/html/HTMLAnchorElement.cpp (revision 51859) > > +++ WebCore/html/HTMLAnchorElement.cpp (working copy) > > @@ -36,6 +36,7 @@ > > #include "Page.h" > > #include "RenderImage.h" > > #include "Settings.h" > > +#include "SpaceSplitString.h" > > I don't understand how the name change triggered the need for an additional > include. > > I'm going to say r=me but I think both of those are errors. The build file > changes look right to me. That seems reasonable. I'll change both prior to landing. Thanks! |