Bug 32235

Summary: Chromium buildbots are not red when they fail
Product: WebKit Reporter: Yaar Schnitman <yaar>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
make buildbot red when checkout and compile fail none

Yaar Schnitman
Reported 2009-12-07 11:49:25 PST
Error returns code are not properly processed.
Attachments
make buildbot red when checkout and compile fail (1013 bytes, patch)
2009-12-07 12:31 PST, Yaar Schnitman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yaar Schnitman
Comment 1 2009-12-07 12:31:13 PST
Created attachment 44424 [details] make buildbot red when checkout and compile fail
WebKit Review Bot
Comment 2 2009-12-07 12:34:34 PST
style-queue ran check-webkit-style on attachment 44424 [details] without any errors.
WebKit Commit Bot
Comment 3 2009-12-07 12:42:55 PST
Comment on attachment 44424 [details] make buildbot red when checkout and compile fail Rejecting patch 44424 from commit-queue. yaar@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. - If you have committer rights please correct the error in WebKitTools/Scripts/modules/committers.py by adding yourself to the file (no review needed) and then set the committer flag again. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
WebKit Commit Bot
Comment 4 2009-12-07 13:30:29 PST
Comment on attachment 44424 [details] make buildbot red when checkout and compile fail Rejecting patch 44424 from commit-queue. yaar@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. - If you have committer rights please correct the error in WebKitTools/Scripts/modules/committers.py by adding yourself to the file (no review needed) and then set the committer flag again. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
WebKit Commit Bot
Comment 5 2009-12-07 13:52:31 PST
Comment on attachment 44424 [details] make buildbot red when checkout and compile fail Clearing flags on attachment: 44424 Committed r51794: <http://trac.webkit.org/changeset/51794>
WebKit Commit Bot
Comment 6 2009-12-07 13:52:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.