Bug 32226

Summary: Random crashes in WebSocket tests on Leopard Debug
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Critical CC: ap, ukai, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Macintosh Intel   
OS: OS X 10.5   
URL: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r51768%20(7949)/results.html
Attachments:
Description Flags
proposed fix zimmermann: review+

Description Nikolas Zimmermann 2009-12-07 09:18:19 PST
See Leopard Intel Debug slave, the new test in websocket/tests/url-with-credential.html crashes.
Adding to the skipped list, until anyone resolves it.
Comment 1 Alexey Proskuryakov 2009-12-07 10:56:47 PST
Disabling the test didn't help - now the next test fails, so it's one of earlier tests that is to blame. Investigating.
Comment 2 Alexey Proskuryakov 2009-12-07 11:12:34 PST
Un-skipped the test.

Running 'run-webkit-tests websocket --repeat-each 5 -v' locally, I'm getting a crash in websocket/tests/handshake-error.html, which looks like memory corruption.

Thread 0 Crashed:
0   com.apple.CoreFoundation      	0x94b7fde6 CFEqual + 38
1   com.apple.CoreFoundation      	0x94b81835 __CFSetFindBuckets2 + 293
2   com.apple.CoreFoundation      	0x94b82be8 CFSetAddValue + 360
3   com.apple.CoreFoundation      	0x94b7c07e CFRunLoopAddTimer + 478
4   com.apple.WebCore             	0x04c65929 WebCore::setSharedTimerFireTime(double) + 291 (SharedTimerMac.mm:103)
5   com.apple.WebCore             	0x04daa5a5 WebCore::MainThreadSharedTimer::setFireTime(double) + 33 (SharedTimer.h:65)
6   com.apple.WebCore             	0x04daa09d WebCore::ThreadTimers::updateSharedTimer() + 141 (ThreadTimers.cpp:85)
7   com.apple.WebCore             	0x04daa23b WebCore::ThreadTimers::sharedTimerFiredInternal() + 381 (ThreadTimers.cpp:122)
8   com.apple.WebCore             	0x04daa2ef WebCore::ThreadTimers::sharedTimerFired() + 27 (ThreadTimers.cpp:91)
9   com.apple.WebCore             	0x04c657b0 __ZN7WebCoreL10timerFiredEP16__CFRunLoopTimerPv + 78 (SharedTimerMac.mm:87)
10  com.apple.CoreFoundation      	0x94b7d8f5 CFRunLoopRunSpecific + 4469
Comment 3 Alexey Proskuryakov 2009-12-07 12:56:40 PST
Created attachment 44426 [details]
proposed fix
Comment 4 WebKit Review Bot 2009-12-07 13:00:25 PST
style-queue ran check-webkit-style on attachment 44426 [details] without any errors.
Comment 5 Nikolas Zimmermann 2009-12-07 13:04:36 PST
Comment on attachment 44426 [details]
proposed fix

Looks good. r=me.
Comment 6 Alexey Proskuryakov 2009-12-07 13:06:04 PST
Committed revision 51790.