Bug 32204

Summary: REGRESSION (r51728): update-webkit fails when the current directory is not inside a Subversion working copy
Product: WebKit Reporter: mitz
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Invoke isSVN() in the correct working directory adele: review+

mitz
Reported 2009-12-06 18:01:49 PST
update-webkit fails when the current directory is not inside a Subversion working copy. Prior to r51728, the script worked when invoked from any directory, and updated the working copy.
Attachments
Invoke isSVN() in the correct working directory (1.24 KB, patch)
2009-12-06 18:09 PST, mitz 		adele: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2009-12-06 18:09:31 PST
Created attachment 44372 [details] Invoke isSVN() in the correct working directory
WebKit Review Bot
Comment 2 2009-12-06 18:13:01 PST
style-queue ran check-webkit-style on attachment 44372 [details] without any errors.
mitz
Comment 3 2009-12-06 19:28:25 PST
Fixed in <http://trac.webkit.org/projects/webkit/changeset/51745>
Adam Barth
Comment 4 2009-12-06 20:58:18 PST
Sorry for the regression. I wish we had tests for these scripts. Thanks for cleaning up after me.
Note You need to log in before you can comment on or make changes to this bug.