| Summary: | [check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) { | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric, levin, mjs, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Created attachment 44488 [details]
Patch
style-queue ran check-webkit-style on attachment 44488 [details] without any errors.
Created attachment 44492 [details]
Patch
style-queue ran check-webkit-style on attachment 44492 [details] without any errors.
Comment on attachment 44492 [details]
Patch
Very clever. Hopefully not too clever. :)
I might add 0-9 in the character class in case we have numbers in the macro names MSG_ROUTED3, etc.
Comment on attachment 44492 [details]
Patch
I'll do the change suggested by Adam and land this.
Commited (with the suggested change) as http://trac.webkit.org/changeset/51876 |
DEFINE_OPCODE(op_jtrue) { generates the warning JavaScriptCore/interpreter/Interpreter.cpp:2650: Place brace on its own line for function definitions. [whitespace/braces] [4] However, this is a false positive <https://bugs.webkit.org/show_bug.cgi?id=32190#c8> because this is some sort of macro. Maybe we should notice the ALL CAPS "function" name and skip the brace check?