Bug 321822
| Summary: | [Site Isolation] Web Inspector: Don't report duplicate Page.frameNavigated events per frame commit | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Qianlang Chen <qianlangchen> |
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | inspector-bugzilla-changes, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
Qianlang Chen
A frame commit reports Page.frameNavigated twice, once from the in-process InspectorPageAgent and once from the per-frame PageAgentProxy, and the frontend's handling of the second report re-initializes the frame -- discarding the child frames, resources, and execution contexts it already learned about. The worst case is nested iframes, where a parent's duplicate arriving after its children attached detachesa live subtree
Address this to prevent breakages when we enable old and new Page domains at the same time, in Bug 321738 (rdar://184867249)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/184962162>
Qianlang Chen
https://github.com/WebKit/WebKit/pull/71672
EWS
Committed 320271@main (42583e7e49eb): <https://commits.webkit.org/320271@main>
Reviewed commits have been landed. Closing PR #71672 and removing active labels.