Bug 32151 – String::append(const String& str) check whether str.length() != 0

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Zoltan Herczeg]

In CachedScript.cpp:

const String& CachedScript::script()
{
    ASSERT(!isPurgeable());

    if (!m_script && m_data) {
        m_script = m_decoder->decode(m_data->data(), encodedSize());
        m_script += m_decoder->flush();
        setDecodedSize(m_script.length() * sizeof(UChar));
    }

    m_decodedDataDeletionTimer.startOneShot(0);
    return m_script;
}

m_decoder->flush() usually returns with an empty string. However, the append duplicates the original string even in this case. (The script can be half mbyte or more). This is an unnecessary allocation and copy.

[Zoltan Herczeg]

Created attachment 44309 [details]
(Platform) String append patch

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44309 [details] without any errors.

[WebKit Commit Bot]

Comment on attachment 44309 [details]
(Platform) String append patch

Clearing flags on attachment: 44309

Committed r51705: <http://trac.webkit.org/changeset/51705>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.