| Summary: | [Qt] New layout tests result added | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abecsi, commit-queue, eric, webkit.review.bot | ||||
| Priority: | P3 | Keywords: | Qt | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
Created attachment 44269 [details]
proposed patch
style-queue ran check-webkit-style on attachment 44269 [details] without any errors.
Comment on attachment 44269 [details]
proposed patch
OK.
I'm surprised this needs to be a render tree dump at all. :(
Comment on attachment 44269 [details] proposed patch Clearing flags on attachment: 44269 Committed r51665: <http://trac.webkit.org/changeset/51665> All reviewed patches have been landed. Closing bug. (In reply to comment #3) > (From update of attachment 44269 [details]) > OK. > > I'm surprised this needs to be a render tree dump at all. :( Thx. I attached the diff for reviewer to check validity easily. Do you say this kind of patches don't need detailed diffs? No, my comment was that I don't think this test shoudl have been written as a render tree dump. It could have been dumpAsText() with the proper getComputedStyle() calls to validate that the text was green. |
There are two new tests seem to be good if compared to the Mac expected png files. We can find only some pixel differences. --- /home/ossy/webkit/LayoutTests/platform/mac/fast/css/namespaces/namespaces-escapes-expected.txt 2009-12-02 18:14:34.000000000 -0600 +++ /home/ossy/webkit/LayoutTests/platform/qt/fast/css/namespaces/namespaces-escapes-expected.txt 2009-12-03 17:55:23.000000000 -0600 @@ -1,8 +1,8 @@ layer at (0,0) size 800x600 RenderView at (0,0) size 800x600 -layer at (0,0) size 800x50 - RenderBlock {html} at (0,0) size 800x50 - RenderBody {body} at (8,16) size 784x18 - RenderBlock {p} at (0,0) size 784x18 [bgcolor=#00FF00] - RenderText {#text} at (0,0) size 299x18 - text run at (0,0) width 299: "This sentence should have a green background." +layer at (0,0) size 800x52 + RenderBlock {html} at (0,0) size 800x52 + RenderBody {body} at (8,16) size 784x20 + RenderBlock {p} at (0,0) size 784x20 [bgcolor=#00FF00] + RenderText {#text} at (0,0) size 341x20 + text run at (0,0) width 341: "This sentence should have a green background." --- /home/ossy/webkit/LayoutTests/platform/mac/fast/css/namespaces/namespaces-invalid-at-expected.txt 2009-12-02 18:14:34.000000000 -0600 +++ /home/ossy/webkit/LayoutTests/platform/qt/fast/css/namespaces/namespaces-invalid-at-expected.txt 2009-12-03 17:55:23.000000000 -0600 @@ -1,17 +1,17 @@ layer at (0,0) size 800x600 RenderView at (0,0) size 800x600 -layer at (0,0) size 800x118 - RenderBlock {html} at (0,0) size 800x118 - RenderBody {body} at (8,16) size 784x86 - RenderBlock {p} at (0,0) size 784x18 - RenderInline {t} at (0,0) size 299x18 [bgcolor=#00FF00] - RenderText {#text} at (0,0) size 299x18 - text run at (0,0) width 299: "This sentence should have a green background." - RenderBlock {p} at (0,34) size 784x18 - RenderInline {t2} at (0,0) size 299x18 [bgcolor=#00FF00] - RenderText {#text} at (0,0) size 299x18 - text run at (0,0) width 299: "This sentence should have a green background." - RenderBlock {p} at (0,68) size 784x18 - RenderInline {t3} at (0,0) size 299x18 [bgcolor=#00FF00] - RenderText {#text} at (0,0) size 299x18 - text run at (0,0) width 299: "This sentence should have a green background." +layer at (0,0) size 800x124 + RenderBlock {html} at (0,0) size 800x124 + RenderBody {body} at (8,16) size 784x92 + RenderBlock {p} at (0,0) size 784x20 + RenderInline {t} at (0,0) size 341x20 [bgcolor=#00FF00] + RenderText {#text} at (0,0) size 341x20 + text run at (0,0) width 341: "This sentence should have a green background." + RenderBlock {p} at (0,36) size 784x20 + RenderInline {t2} at (0,0) size 341x20 [bgcolor=#00FF00] + RenderText {#text} at (0,0) size 341x20 + text run at (0,0) width 341: "This sentence should have a green background." + RenderBlock {p} at (0,72) size 784x20 + RenderInline {t3} at (0,0) size 341x20 [bgcolor=#00FF00] + RenderText {#text} at (0,0) size 341x20 + text run at (0,0) width 341: "This sentence should have a green background."