Bug 32132

Summary:

websocket/tests/simple.html fails on Windows

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebCore Misc.

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, ukai, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
proposed fix	darin: review+

Alexey Proskuryakov

Reported 2009-12-03 13:25:02 PST

<http://build.webkit.org/results/Windows%20Debug%20(Tests)/r51652%20(7132)/websocket/tests/simple-pretty-diff.html>

Attachments
proposed fix (3.14 KB, patch) 2009-12-03 15:37 PST, Alexey Proskuryakov	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brian Weinstein

Comment 1 2009-12-03 13:28:24 PST

Added to Skipped list in r51657.

Alexey Proskuryakov

Comment 2 2009-12-03 13:32:44 PST

I actually think that my changes to the test were incorrect. These events are posted, not dispatched synchronously, so one can't rely on readyState value in a handler.

Alexey Proskuryakov

Comment 3 2009-12-03 15:37:10 PST

Created attachment 44273 [details] proposed fix

WebKit Review Bot

Comment 4 2009-12-03 15:41:00 PST

style-queue ran check-webkit-style on attachment 44273 [details] without any errors.

Alexey Proskuryakov

Comment 5 2009-12-03 16:07:33 PST

Committed revision 51667.

Note You need to log in before you can comment on or make changes to this bug.