Summary: | [check-webkit-style] strcmp should be excepted from readability/comparison_to_zero | ||
---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED INVALID | ||
Severity: | Normal | CC: | ap, levin |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All |
Description
Adam Barth
2009-12-03 11:01:35 PST
We should probably discuss this on webkit-dev first, as the current rules don't allow for such exception. It has been two week with no discussion on webkit-dev to approve this, so I'm resolving as this bug as invalid. Feel free to reactivate if that discussion happens and this is approved. fwiw, I like comparing to 0/NULL for all appropriate items, but it is WebKit style to not to do this and !a is logically equivalent to a == 0 so that's that :) I e-mailed webkit-dev now. |