Bug 32125
| Summary: | [check-webkit-style] strcmp should be excepted from readability/comparison_to_zero | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | ap, levin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Adam Barth
Comment #7 From WebKit Review Bot 2009-12-03 10:36:46 PST (-) [reply]
Attachment 44255 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/KURL.cpp:637: Tests for true/false, null/non-null, and
zero/non-zero should all be done without equality comparisons.
[readability/comparison_to_zero] [5]
Total errors found: 1
Comment #8 From Alexey Proskuryakov 2009-12-03 10:41:21 PST (-) [reply]
I think that strcmp comparisons should be an exception to the rule, but I can
change this when landing if a reviewer tells me to.
https://bugs.webkit.org/show_bug.cgi?id=32085#c8
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
We should probably discuss this on webkit-dev first, as the current rules don't allow for such exception.
David Levin
It has been two week with no discussion on webkit-dev to approve this, so I'm resolving as this bug as invalid.
Feel free to reactivate if that discussion happens and this is approved.
fwiw, I like comparing to 0/NULL for all appropriate items, but it is WebKit style to not to do this and !a is logically equivalent to a == 0 so that's that :)
Alexey Proskuryakov
I e-mailed webkit-dev now.