Bug 32117 – REGRESSION (r51627): 3 SVG tests are failing

• Component: SVG
• Status: RESOLVED FIXED

[Adam Roben (:aroben)]

r51627 <http://trac.webkit.org/changeset/51627> has caused 3 regression tests to fail (including the test that was added in that revision!). See <http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r51627%20(7825)/results.html> for the failures.

[Adam Roben (:aroben)]

<rdar://problem/7440556>

[Oliver Hunt]

Created attachment 44261 [details]
Patch

Comment on attachment 44261 [details]
Patch

r=me modulo typos

[WebKit Review Bot]

Attachment 44261 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/svg/SVGListTraits.h:32:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1

[Oliver Hunt]

Committed r51649

[Adam Roben (:aroben)]

Comment on attachment 44261 [details]
Patch


> +    template<typename ItemPtr>
> +    struct SVGListTraits<true, ItemPtr*> {
> +        static ItemPtr nullItem() { return 0; }
> +        static bool isNull(ItemPtr it) { return !it; }
> +    };

Shouldn't that be:

static ItemPtr* nullItem() { return 0; }
static bool isNull(ItemPtr* it) { return !it; }

> +        static bool isNull(RefPtr<ItemPtr> it) { return !it; }

This would be more efficient if it took a reference to const.