Bug 32117

Summary: REGRESSION (r51627): 3 SVG tests are failing
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mjs, oliver, webkit.review.bot
Priority: P2 Keywords: InRadar, LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
URL: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r51627%20(7825)/results.html
Attachments:
Description Flags
Patch mitz: review+

Description Adam Roben (:aroben) 2009-12-03 07:35:54 PST 
r51627 <http://trac.webkit.org/changeset/51627> has caused 3 regression tests to fail (including the test that was added in that revision!). See <http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r51627%20(7825)/results.html> for the failures.
Comment 1 Adam Roben (:aroben) 2009-12-03 07:36:36 PST 
<rdar://problem/7440556>
Comment 2 Oliver Hunt 2009-12-03 11:25:16 PST 
Created attachment 44261 [details]
Patch
Comment 3 mitz 2009-12-03 11:29:37 PST 
Comment on attachment 44261 [details]
Patch

r=me modulo typos
Comment 4 WebKit Review Bot 2009-12-03 11:29:39 PST 
Attachment 44261 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/svg/SVGListTraits.h:32:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1
Comment 5 Oliver Hunt 2009-12-03 11:35:13 PST 
Committed r51649
Comment 6 Adam Roben (:aroben) 2009-12-03 12:38:40 PST 
Comment on attachment 44261 [details]
Patch


> +    template<typename ItemPtr>
> +    struct SVGListTraits<true, ItemPtr*> {
> +        static ItemPtr nullItem() { return 0; }
> +        static bool isNull(ItemPtr it) { return !it; }
> +    };

Shouldn't that be:

static ItemPtr* nullItem() { return 0; }
static bool isNull(ItemPtr* it) { return !it; }

> +        static bool isNull(RefPtr<ItemPtr> it) { return !it; }

This would be more efficient if it took a reference to const.