Summary: | Centralize web site instructions on using WebKit scripts | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Jerdonek <cjerdonek> | ||||
Component: | WebKit Website | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | CC: | cjerdonek, commit-queue, webkit.review.bot | ||||
Priority: | P4 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Chris Jerdonek
2009-12-03 03:11:59 PST
Created attachment 44223 [details]
Proposed patch
The WebKit/WebKitTools/Scripts path now appears on only one page.
Also fixed a few minor typos, validation issues, etc.
style-queue ran check-webkit-style on attachment 44223 [details] without any errors.
Comment on attachment 44223 [details]
Proposed patch
This seems OK. r=me
The real test is how many people are able to successfully use the the website and follow the instructions without having to ask people on the mailing list. We used to get a lot of "I can't build WebKit" emails on the webkit-dev mailing list.
(In reply to comment #3) > (From update of attachment 44223 [details]) > This seems OK. r=me > > The real test is how many people are able to successfully use the the website > and follow the instructions without having to ask people on the mailing list. > We used to get a lot of "I can't build WebKit" emails on the webkit-dev mailing > list. Understood. An advantage of the approach taken in this patch is that if people need extra "hand-holding" to use the command-line (like with modifying their shell path), we can put those extra details in the new page this patch creates and make that page extra clear. Comment on attachment 44223 [details] Proposed patch Clearing flags on attachment: 44223 Committed r51733: <http://trac.webkit.org/changeset/51733> All reviewed patches have been landed. Closing bug. |