| Summary: | mod_pywebsocket IndexError: string index out of range | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ukai, webkit.review.bot, yuzo | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Mac (Intel) | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
To run the test, please copy echo_wsh.py from pywebsocket examples to LayoutTests/websocket/tests. The browser code doesn't close connection gracefully. echo_wsh.py won't stop until it receives 'Goodbye'. Can you try sending it at the end of the test? Yuzo Will try tomorrow, thanks! But is "string index out of range" an appropriate error to report in such cases? I'm preparing a change for better log messages upstream: http://code.google.com/p/pywebsocket/issues/detail?id=28 I'll file an upgrade patch after the above is committed. Yuzo Created attachment 44222 [details]
Update pywebsocket to 0.4.3
style-queue ran check-webkit-style on attachment 44222 [details] without any errors.
Comment on attachment 44222 [details]
Update pywebsocket to 0.4.3
LGTM
Comment on attachment 44222 [details] Update pywebsocket to 0.4.3 Clearing flags on attachment: 44222 Committed r51661: <http://trac.webkit.org/changeset/51661> All reviewed patches have been landed. Closing bug. Created attachment 44380 [details]
Add run-webkit-websocketserver
style-queue ran check-webkit-style on attachment 44380 [details] without any errors.
Addressed the comment. Can you take another look? Yuzo Looks like the attachment is in a wrong bug. Comment on attachment 44380 [details]
Add run-webkit-websocketserver
sorry, wrong attachment.
|
Created attachment 44196 [details] test case Running the attached test result in a PASS in browser, but there is an exception in server, which doesn't seem right: [2009-12-02 17:17:55,436] [WARNING] root: mod_pywebsocket: web_socket_transfer_data raised exception: Traceback (most recent call last): File "/Users/ap/Safari/OpenSource/WebKitTools/pywebsocket/mod_pywebsocket/dispatch.py", line 179, in transfer_data transfer_data_(request) File "<string>", line 43, in web_socket_transfer_data File "/Users/ap/Safari/OpenSource/WebKitTools/pywebsocket/mod_pywebsocket/msgutil.py", line 67, in receive_message frame_type = ord(frame_type_str[0]) IndexError: string index out of range