Bug 32090

Summary:

Fix Qt --no-svg/--minimal build

Product:

WebKit

Reporter:

Robert Hogan <robert>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
patch	eric: review-
patch	eric: review+, commit-queue: commit-queue-

Robert Hogan

Reported 2009-12-02 14:10:34 PST

Fix Qt --no-svg/--minimal build

Attachments
patch (1.76 KB, patch) 2009-12-02 14:12 PST, Robert Hogan	eric: review-	Details Formatted Diff Diff
patch (1.77 KB, patch) 2009-12-03 11:21 PST, Robert Hogan	eric: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Robert Hogan

Comment 1 2009-12-02 14:12:31 PST

Created attachment 44183 [details] patch

Eric Seidel (no email)

Comment 2 2009-12-02 15:35:51 PST

Comment on attachment 44183 [details] patch Please fix your full name in the ChangeLog. Otherwise this looks fine. You might take a look at the "important git config settings" in http://trac.webkit.org/wiki/UsingGitWithWebKit

Robert Hogan

Comment 3 2009-12-03 11:21:55 PST

Created attachment 44259 [details] patch

WebKit Review Bot

Comment 4 2009-12-03 11:23:48 PST

style-queue ran check-webkit-style on attachment 44259 [details] without any errors.

Eric Seidel (no email)

Comment 5 2009-12-03 15:20:40 PST

Comment on attachment 44259 [details] patch Thanks!

WebKit Commit Bot

Comment 6 2009-12-03 15:24:50 PST

Comment on attachment 44259 [details] patch Rejecting patch 44259 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1 Last 500 characters of output: o-svg build. --- WebKit/qt/Api/qwebframe.cpp | 2 +- WebKit/qt/ChangeLog | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletions(-) ------------------------------------------------------------------- patching file WebKit/qt/Api/qwebframe.cpp Hunk #1 succeeded at 131 with fuzz 2 (offset -22 lines). Hunk #2 FAILED at 146. 1 out of 2 hunks FAILED -- saving rejects to file WebKit/qt/Api/qwebframe.cpp.rej patching file WebKit/qt/ChangeLog Hunk #1 succeeded at 1 with fuzz 3.

Eric Seidel (no email)

Comment 7 2009-12-07 11:33:36 PST

Looks like this patch rotted.

Robert Hogan

Comment 8 2009-12-07 11:44:31 PST

fixed in trunk

Note You need to log in before you can comment on or make changes to this bug.