Bug 32071
| Summary: | bugzilla-tool post-* and land-* should ask for confirmation before posting/landing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ddkilzer, hamaji, levin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
| Bug Depends on: | |||
| Bug Blocks: | 31757 | ||
Eric Seidel (no email)
bugzilla-tool post-* should ask for confirmation before posting
https://bugs.webkit.org/show_bug.cgi?id=32051#c4
Something like:
> bugzilla-tool post-diff
Parsing ChangeLog
About to post 12k patch titled "Patch" containing changes to 5 files:
WebCore/ChangeLog
WebCore/dom/Document.cpp
LayoutTests/ChangeLog
LayoutTests/fast/dom/Document-not-suck.html
LayoutTests/fast/dom/Document-not-suck-expected.txt
to bug 12345 "Fix Document.cpp not to suck".
For post-* we can ask about accepting the licenses, which is covered by bug 31757. You don't have to do that in the first pass, but whoever adds license confirmation can just tack it on the same confirmation message, since we wouldn't need two separate prompts.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
Yay! They do now. :)
Well, at least they show you the diff. They could do more, but I think we can close this for now.