| Summary: | Chromium: Need tickmarks in scrollbar | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Avi Drissman <avi> | ||||||||
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, fishd, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Avi Drissman
2009-12-02 09:08:38 PST
Created attachment 44154 [details]
Patch to implement tickmarks
Note that in review, please compare ScrollbarThemeChromiumMac.* to ScrollbarThemeMac.*. It should be pretty self-explanatory.
style-queue ran check-webkit-style on attachment 44154 [details] without any errors.
Created attachment 44156 [details]
Now with svn cp!
style-queue ran check-webkit-style on attachment 44156 [details] without any errors.
Comment on attachment 44156 [details]
Now with svn cp!
The code is all fine. However, I'm concerned about the forking.
It seems like it would be nice to share code with ScrollbarThemeChromium.cpp
for drawing the tickmarks and to share code with ScrollbarThemeMac.mm for
much of the other bits.
-Darin
Comment on attachment 44156 [details]
Now with svn cp!
Avi explained why it has to be this way for now. We have forked RenderTheme similarly.
This will eventually become a painful thing to deal with, and I'm very interested in
finding a better solution.
But, for now r=me
Comment on attachment 44156 [details] Now with svn cp! Clearing flags on attachment: 44156 Committed r51603: <http://trac.webkit.org/changeset/51603> All reviewed patches have been landed. Closing bug. Created attachment 44538 [details]
Patch to draw scrollbar ticks. Now with UX approval!
Sigh. UX says we need to draw these prettier. Avi, does that last comment imply that this patch should no longer be up for review? (In reply to comment #11) > Avi, does that last comment imply that this patch should no longer be up for > review? Sorry. The latest patch, posted this morning, is what UX approved. It's up for review. Comment on attachment 44538 [details]
Patch to draw scrollbar ticks. Now with UX approval!
r=me
Comment on attachment 44538 [details]
Patch to draw scrollbar ticks. Now with UX approval!
Rejecting patch 44538 from commit-queue.
Unexpected failure when landing patch! Please file a bug against bugzilla-tool.
Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44538']" exit_code: 1
Last 500 characters of output:
nd_handle_errors
self.run()
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 54, in run
self.clean()
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in clean
step.run()
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/buildsteps.py", line 101, in run
os.chdir(self._tool._scm.checkout_root)
AttributeError: 'NoneType' object has no attribute 'checkout_root'
Comment on attachment 44538 [details]
Patch to draw scrollbar ticks. Now with UX approval!
Can we try committing again?
Comment on attachment 44538 [details] Patch to draw scrollbar ticks. Now with UX approval! Rejecting patch 44538 from commit-queue. avi@drissman.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. - If you have committer rights please correct the error in WebKitTools/Scripts/modules/committers.py by adding yourself to the file (no review needed) and then set the committer flag again. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. Comment on attachment 44538 [details]
Patch to draw scrollbar ticks. Now with UX approval!
Sorry for the noise. Adam believes to have fixed the issue. I've restarted the commit bot.
Comment on attachment 44538 [details] Patch to draw scrollbar ticks. Now with UX approval! Clearing flags on attachment: 44538 Committed r51909: <http://trac.webkit.org/changeset/51909> All reviewed patches have been landed. Closing bug. |