Bug 32055

Summary:

Add test for cross-origin WebSocket usage

Product:

WebKit

Reporter:

Fumitoshi Ukai <ukai>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Add tests for cross-origin WebSocket usage	ap: review+

Fumitoshi Ukai

Reported 2009-12-02 00:22:32 PST

Add many new tests for cross-origin WebSocket usage to check that it functions correctly.

Attachments
Add tests for cross-origin WebSocket usage (13.23 KB, patch) 2009-12-03 21:16 PST, Fumitoshi Ukai	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2009-12-02 11:27:50 PST

Some existing tests (e.g. frame-length-skip) currently use ws://localhost:8880 - these need to be evaluated for correctness, too.

Fumitoshi Ukai

Comment 2 2009-12-03 21:16:45 PST

Created attachment 44287 [details] Add tests for cross-origin WebSocket usage

WebKit Review Bot

Comment 3 2009-12-03 21:17:56 PST

style-queue ran check-webkit-style on attachment 44287 [details] without any errors.

Alexey Proskuryakov

Comment 4 2009-12-04 13:00:45 PST

Both ws://localhost:8880 and ws://127.0.0.1:8880 are cross-origin if the test itself is served from http://127.0.0.1:8000. So, changing one for another doesn't seem to make much sense. I got somewhat confused about how origin-based authentication works for WebSocket - unlike XMLHttpRequest, it doesn't have a "only same origin" legacy, so it doesn't matter which server URL to use.

Alexey Proskuryakov

Comment 5 2009-12-04 13:07:46 PST

And now I just realized that the tests are loaded from ws://127.0.0.1:8880, sorry for the noise. Maybe we could change the port for websocket tests to not look that similar to port 8000?

Alexey Proskuryakov

Comment 6 2009-12-04 13:33:11 PST

Comment on attachment 44287 [details] Add tests for cross-origin WebSocket usage Looks good, r=me. One general note: it would be nice if parts of _wsh.py scripts' functionality could be shared between tests. We could use URL queries to pass parameters to them. Of course, combining them all into one script should not be a goal, but reducing the number of files necessary for an average test would be good.

Fumitoshi Ukai

Comment 7 2009-12-06 18:23:05 PST

Committed r51743: <http://trac.webkit.org/changeset/51743>

Fumitoshi Ukai

Comment 8 2009-12-06 18:25:56 PST

(In reply to comment #6) > (From update of attachment 44287 [details]) > Looks good, r=me. Thanks for review! > > One general note: it would be nice if parts of _wsh.py scripts' functionality > could be shared between tests. We could use URL queries to pass parameters to > them. > > Of course, combining them all into one script should not be a goal, but > reducing the number of files necessary for an average test would be good. Agree. I'll create another patch.

Note You need to log in before you can comment on or make changes to this bug.