Bug 32038

Summary: http/tests/cache/subresource-failover-to-network.html is Flaky on Windows
Product: WebKit Reporter: Brian Weinstein <bweinstein>
Component: Tools / TestsAssignee: Darin Fisher (:fishd, Google) <fishd>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, bweinstein, webkit.review.bot
Priority: P2 Keywords: PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows Vista   
URL: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r51558%20(7055)/http/tests/cache/subresource-failover-to-network-pretty-diff.html
Attachments:
Description Flags
v1 patch: rewrite the test to avoid dump{Frame,Resource}LoadCalllbacks darin: review+

Brian Weinstein
Reported 2009-12-01 15:10:01 PST
This test is flaky on Windows, and has been since it was first added to the repository. All of the loads appear to be happening, but sometimes: http://127.0.0.1:8000/cache/resources/subresource-failover-to-network.cgi - didFinishLoading Happens before: main frame - didFinishDocumentLoadForFrame main frame - didHandleOnloadEventsForFrame main frame - didFinishLoadForFrame Instead of after. Here is a log of the test in the way it fails: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r51558%20(7055)/http/tests/cache/subresource-failover-to-network-pretty-diff.html
Attachments
v1 patch: rewrite the test to avoid dump{Frame,Resource}LoadCalllbacks (6.62 KB, patch)
2009-12-07 13:54 PST, Darin Fisher (:fishd, Google) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2009-12-01 23:14:25 PST
This test is also flaky for the chromium bots: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=subresource-failover-to-network
Brian Weinstein
Comment 2 2009-12-02 13:12:05 PST
Added to Windows Skipped list in r51611, make sure to take it off when the test is deflakified.
Darin Fisher (:fishd, Google)
Comment 3 2009-12-07 13:54:51 PST
Created attachment 44431 [details] v1 patch: rewrite the test to avoid dump{Frame,Resource}LoadCalllbacks
WebKit Review Bot
Comment 4 2009-12-07 13:57:43 PST
style-queue ran check-webkit-style on attachment 44431 [details] without any errors.
Darin Fisher (:fishd, Google)
Comment 5 2009-12-07 14:44:09 PST
Landed as http://trac.webkit.org/changeset/51798 I also unskipped this test on platform/win.
Note You need to log in before you can comment on or make changes to this bug.