Bug 32033

Summary: check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, hamaji, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
none
check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h eric: review+

Description Eric Seidel (no email) 2009-12-01 13:25:57 PST 
check-webkit-style does not understand *(Custom|Gtk|CG|Mac).cpp including *.h

We have a bunch of files in WebCore which share a common header, one example is our JS Custom bindings:
https://bugs.webkit.org/show_bug.cgi?id=30206#c6
Comment 1 David Levin 2009-12-01 16:28:48 PST 
Fixed title (as it did understand the prior form :) ).
Comment 2 David Levin 2009-12-01 16:55:51 PST 
Created attachment 44111 [details]
2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
Comment 3 David Levin 2009-12-01 16:56:34 PST 
Created attachment 44112 [details]
check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
Comment 4 WebKit Review Bot 2009-12-01 16:58:52 PST 
style-queue ran check-webkit-style on attachment 44112 [details] without any errors.
Comment 5 Eric Seidel (no email) 2009-12-01 17:04:30 PST 
Comment on attachment 44112 [details]
check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h

LGTM.  Thanks!
Comment 6 David Levin 2009-12-01 17:28:04 PST 
Committed as http://trac.webkit.org/changeset/51570