Bug 32033

Summary: check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, hamaji, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
none
check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h eric: review+

Eric Seidel (no email)
Reported 2009-12-01 13:25:57 PST
check-webkit-style does not understand *(Custom|Gtk|CG|Mac).cpp including *.h We have a bunch of files in WebCore which share a common header, one example is our JS Custom bindings: https://bugs.webkit.org/show_bug.cgi?id=30206#c6
Attachments
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> (49.57 KB, patch)
2009-12-01 16:55 PST, David Levin 		no flags
DetailsFormatted DiffDiff
check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h (2.47 KB, patch)
2009-12-01 16:56 PST, David Levin 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-12-01 16:28:48 PST
Fixed title (as it did understand the prior form :) ).
David Levin
Comment 2 2009-12-01 16:55:51 PST
Created attachment 44111 [details] 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
David Levin
Comment 3 2009-12-01 16:56:34 PST
Created attachment 44112 [details] check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
WebKit Review Bot
Comment 4 2009-12-01 16:58:52 PST
style-queue ran check-webkit-style on attachment 44112 [details] without any errors.
Eric Seidel (no email)
Comment 5 2009-12-01 17:04:30 PST
Comment on attachment 44112 [details] check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h LGTM. Thanks!
David Levin
Comment 6 2009-12-01 17:28:04 PST
Committed as http://trac.webkit.org/changeset/51570
Note You need to log in before you can comment on or make changes to this bug.