Bug 32032

Summary:

@namespace directives should allow empty namespaces

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

CSS

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

URL:

http://www.w3.org/Style/CSS/Test/CSS3/Namespace/20090210/prefix-004.xml

Attachments:

Description	Flags
Patch	simon.fraser: review+

Dave Hyatt

Reported 2009-12-01 13:19:38 PST

Right now empty namespaces are incorrectly ignored.

Attachments
Patch (2.62 KB, patch) 2009-12-01 13:21 PST, Dave Hyatt	simon.fraser: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2009-12-01 13:21:55 PST

Created attachment 44097 [details] Patch

WebKit Review Bot

Comment 2 2009-12-01 13:24:28 PST

Attachment 44097 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/css/CSSStyleSheet.cpp:154: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1

Dave Hyatt

Comment 3 2009-12-01 13:32:14 PST

Thanks reviewbot! I have fixed that style issue.

Dave Hyatt

Comment 4 2009-12-01 13:32:34 PST

Fixed in r51556.

Note You need to log in before you can comment on or make changes to this bug.