Bug 32015

Summary: Update expectations of css2.1/t1205-c56* for Qt
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch v1 eric: review+

Shinichiro Hamaji
Reported 2009-12-01 03:27:14 PST
I've marked some tests as skipped for Qt in Bug 23264. Update the expectations of some of them. Note that other tests will be fixed in Bug 32014 by converting the tests into dumpAsText tests.
Attachments
Patch v1 (4.88 KB, patch)
2009-12-01 03:28 PST, Shinichiro Hamaji 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2009-12-01 03:28:37 PST
Created attachment 44065 [details] Patch v1
WebKit Review Bot
Comment 2 2009-12-01 03:31:28 PST
style-queue ran check-webkit-style on attachment 44065 [details] without any errors.
Eric Seidel (no email)
Comment 3 2009-12-01 07:20:25 PST
Comment on attachment 44065 [details] Patch v1 OK. Looks sane to me.
Shinichiro Hamaji
Comment 4 2009-12-01 21:50:21 PST
Committed r51586: <http://trac.webkit.org/changeset/51586>
Shinichiro Hamaji
Comment 5 2009-12-01 22:32:06 PST
CCing original authors of these tests. Darin, I understand your concern. I confirmed that these tests fail if I reverse-patch the following fixes. Of course, I know this fact doesn't show I didn't lose any information from the original test, though. Please let me know if there are some more information I can tell. Or, if you feel you'd never be confident, please let me know and I'll just update the expectations of these tests. https://bugs.webkit.org/show_bug.cgi?id=13887 https://bugs.webkit.org/show_bug.cgi?id=12746
Shinichiro Hamaji
Comment 6 2009-12-01 22:32:57 PST
Oops, I posted the comment on wrong bug... Please just ignore.
Note You need to log in before you can comment on or make changes to this bug.