Summary: | webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | Tools / Tests | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ojan, twiz, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2009-11-30 21:49:25 PST
We just need some sort of "EnsureBugIsOpen" step. Shouldn't be hard to write. Created attachment 98964 [details]
Patch
Comment on attachment 98964 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98964&action=review I'd add the user confirmation step, but that's a judgement call. > Tools/Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py:41 > + if bug.is_closed(): > + # FIXME: We should probably pass this message in somehow? > + # Right now this step is only used before PostDiff steps, so this is OK. > + self._tool.bugs.reopen_bug(bug.id(), "Reopening to attach new patch.") It sucks that bugzilla needs you to spam a bug in order to re-open it. Why not ask the user to confirm before doing this? I'm happy to ask the user to confirm, or ask the user for a message. Either change is very easy to make. Comment on attachment 98964 [details]
Patch
Dammit reviewers not setting cq+ on my patches. I can't believe I wrote a patch for this 6 months ago and forget about it. :p
I really doubt this still applies.
Comment on attachment 98964 [details] Patch Rejecting attachment 98964 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: arechangelog.py Hunk #1 succeeded at 63 (offset -1 lines). patching file Tools/Scripts/webkitpy/tool/steps/steps_unittest.py Hunk #2 FAILED at 57. 1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/tool/steps/steps_unittest.py.rej patching file Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py Hunk #1 succeeded at 43 with fuzz 2. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10696732 Committed r101834: <http://trac.webkit.org/changeset/101834> |