Bug 320041
| Summary: | [Site Isolation] Zoom-to-reveal mispositions the focused element when the selection is in a cross-origin iframe | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | New Bugs | Assignee: | zak ridouh <zakr> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
-[WKContentView _zoomToRevealFocusedElement] intersected the selection rect
(in the selection's own subframe coordinates) with interactionRect (already
in main-frame coordinates). Under site isolation these differ for an offset
iframe, so the reveal targeted the wrong place.
Convert the selection rect to main-frame coordinates before intersecting,
matching 59c6b9895dec. The conversion is synchronous and identity for a
main-frame selection, so existing behavior is unchanged; only a cross-origin
subframe selection takes the async path, from a completion handler that
re-validates focus state.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/182974019>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/69992
EWS
Committed 320242@main (9543685f56f5): <https://commits.webkit.org/320242@main>
Reviewed commits have been landed. Closing PR #69992 and removing active labels.