Bug 32001

Summary: Add missing localized strings for tooltip image dimensions
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Web Inspector (Deprecated)Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, bweinstein, commit-queue, eric, joepeck, kmccullough, pfeldman, pmuellr, rik, timothy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch with rebased test case
none
Patch with rebased test case none

Daniel Bates
Reported 2009-11-30 15:26:45 PST
I forgot to add the localized strings for the tooltip to the file localizedStrings.js as part of my patch for bug #21554. Also, changed the strings a bit to make them conform to our style of having a space between the multiply character.
Attachments
Patch with rebased test case (40.91 KB, patch)
2009-11-30 19:07 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch with rebased test case (41.04 KB, patch)
2009-11-30 19:20 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2009-11-30 19:07:54 PST
Created attachment 44050 [details] Patch with rebased test case
WebKit Review Bot
Comment 2 2009-11-30 19:09:47 PST
style-queue ran check-webkit-style on attachment 44050 [details] without any errors.
Daniel Bates
Comment 3 2009-11-30 19:20:24 PST
Created attachment 44051 [details] Patch with rebased test case Made the change log more descriptive as per Brian's suggestion on IRC.
WebKit Review Bot
Comment 4 2009-11-30 19:25:23 PST
style-queue ran check-webkit-style on attachment 44051 [details] without any errors.
WebKit Commit Bot
Comment 5 2009-12-01 14:12:08 PST
Comment on attachment 44051 [details] Patch with rebased test case Clearing flags on attachment: 44051 Committed r51559: <http://trac.webkit.org/changeset/51559>
WebKit Commit Bot
Comment 6 2009-12-01 14:12:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.