Summary: | [Qt][Symbian] Report SymbianOS in user agent string for Symbian | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> | ||||||
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, commit-queue, hausmann | ||||||
Priority: | P2 | Keywords: | Qt | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | S60 3rd edition | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 27065 | ||||||||
Attachments: |
|
Description
Laszlo Gombos
2009-11-29 12:46:34 PST
Created attachment 43991 [details]
1st try
Abhinav is out for the rest of the year, I uploading his patch on his behalf.
Comment on attachment 43991 [details] 1st try In principle I think this patch looks good, but there are a few style issues: > + // Placeholder for SubPlatfrom Version from -> form > + "%4; "); > + > +// Platform Version This should be indented 4 spaces > + QString osVer; > +#ifdef Q_OS_SYMBIAN > + QSysInfo::SymbianVersion symbianVersion = QSysInfo::symbianVersion(); > +switch (symbianVersion) { This line is also missing indentation. > + case QSysInfo::SV_9_2: > + osVer = "/9.2"; > + break; > + case QSysInfo::SV_9_3: > + osVer = "/9.3"; > + break; > + case QSysInfo::SV_9_4: > + osVer = "/9.4"; > + break; > + default: > + osVer = "Unknown"; > + } > +#else > + osVer = ""; > +#endif I suggest to omit the #else block that assigns an empty string to the string that is already a null string. > +// SubPlatform Version Indentation > + QString subPlatformVer; > +#ifdef Q_OS_SYMBIAN > + QSysInfo::S60Version s60Version = QSysInfo::s60Version(); > +switch (s60Version) { Indentation > + case QSysInfo::SV_S60_3_1: > + subPlatformVer = "/3.1"; > + break; > + case QSysInfo::SV_S60_3_2: > + subPlatformVer = "/3.2"; > + break; > + case QSysInfo::SV_S60_5_0: > + subPlatformVer = "/5.0"; > + break; > + default: > + subPlatformVer = " Unknown"; > + } > +#else > + subPlatformVer = ""; > +#endif Same as above, the assignment is unnecessary. Created attachment 44005 [details]
2nd try
Incorporate Simon's review comments.
style-queue ran check-webkit-style on attachment 44005 [details] without any errors.
Comment on attachment 44005 [details] 2nd try Clearing flags on attachment: 44005 Committed r51515: <http://trac.webkit.org/changeset/51515> All reviewed patches have been landed. Closing bug. |