Bug 31953 – [Qt] [code cleaning] Clean the code paths of QWebFrame::render()

• Component: WebKit Qt
• Status: RESOLVED INVALID

[Benjamin Poulain]

Some implementation of QWebFrame::render() check if the frame is valid, other don't.

This check is done by QWebFramePrivate::renderPrivate() anyway: 

void QWebFramePrivate::renderPrivate(QPainter *painter, QWebFrame::RenderLayer layer, const QRegion &clip)
{
    if (!frame->view() || !frame->contentRenderer())
        return;

so their is no need to check in QWebFrame.

[Benjamin Poulain]

Created attachment 43982 [details]
Remove the extra if()

[Eric Seidel (no email)]

Comment on attachment 43982 [details]
Remove the extra if()

This will crash grabbing ->frameRect()

[Benjamin Poulain]

Created attachment 43983 [details]
Check the view once.

Thanks Eric, I was working on something else and I did not think much this change.

The modified patch does not clean much so I guess it's not worth it.

[Eric Seidel (no email)]

Comment on attachment 43983 [details]
Check the view once.

I'm not sure this is really any more clear.  Especially it seems kinda strange to turn the if into an ASSERT in renderPrivate.

I'd be OK with this if you were just cleaning up render(4 args) as you have, but it seems strange to change renderPrivate and rendner(QPainter*) too.

[Benjamin Poulain]

There is a refactoring of the painting code going on. This issue can be better addressed there.

[Antonio Gomes]

(In reply to comment #5)
> There is a refactoring of the painting code going on. This issue can be better
> addressed there.

benjamin , bug # of this refactorying ? :)

[Benjamin Poulain]

(In reply to comment #6)
> benjamin , bug # of this refactorying ? :)

No bug yet. Kenneth and I are working on it. We will create a bug when something is working (should be soon).