Summary: | style-queue should only process each patch once | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Adam Barth
2009-11-27 11:32:29 PST
Created attachment 43963 [details]
Patch
Created attachment 43964 [details]
initial status
Created attachment 43965 [details]
initial status
Comment on attachment 43965 [details]
initial status
.cached_scm was a name from a naiver time. :) I think we shoudl just call it ._scm now.
I feel like PatchCollection hasn't quite figured out what it is yet. :( Part of me thinks we shoudl make somethign that works perfectly for hte style queue and worry about abstracting it later, since I had to rip PatchCollection out of commit-queue already. :(
Looks OK though. I'd prefer we went with _scm and _statusbot though.
Comment on attachment 43965 [details] initial status Clearing flags on attachment: 43965 Committed r51447: <http://trac.webkit.org/changeset/51447> All reviewed patches have been landed. Closing bug. |