Bug 31939

Summary: style-queue should only process each patch once
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
initial status
initial status none

Description Adam Barth 2009-11-27 11:32:29 PST
We need to integrate style-queue with the status web service to keep persistent state.
Comment 1 Adam Barth 2009-11-27 11:34:40 PST
Created attachment 43963 [details]
Comment 2 Adam Barth 2009-11-27 11:45:10 PST
Created attachment 43964 [details]
initial status
Comment 3 Adam Barth 2009-11-27 11:51:07 PST
Created attachment 43965 [details]
initial status
Comment 4 Eric Seidel (no email) 2009-11-27 15:27:22 PST
Comment on attachment 43965 [details]
initial status

.cached_scm was a name from a naiver time. :)  I think we shoudl just call it ._scm now.

I feel like PatchCollection hasn't quite figured out what it is yet. :(  Part of me thinks we shoudl make somethign that works perfectly for hte style queue and worry about abstracting it later, since I had to rip PatchCollection out of commit-queue already. :(

Looks OK though.  I'd prefer we went with _scm and _statusbot though.
Comment 5 Adam Barth 2009-11-27 15:34:51 PST
Comment on attachment 43965 [details]
initial status

Clearing flags on attachment: 43965

Committed r51447: <http://trac.webkit.org/changeset/51447>
Comment 6 Adam Barth 2009-11-27 15:34:56 PST
All reviewed patches have been landed.  Closing bug.