Bug 31939

Summary:

style-queue should only process each patch once

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
initial status	none
initial status	none

Adam Barth

Reported 2009-11-27 11:32:29 PST

We need to integrate style-queue with the status web service to keep persistent state.

Attachments
Patch (6.87 KB, patch) 2009-11-27 11:34 PST, Adam Barth	no flags	Details Formatted Diff Diff
initial status (8.18 KB, patch) 2009-11-27 11:45 PST, Adam Barth	no flags	Details Formatted Diff Diff
initial status (7.64 KB, patch) 2009-11-27 11:51 PST, Adam Barth	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2009-11-27 11:34:40 PST

Created attachment 43963 [details] Patch

Adam Barth

Comment 2 2009-11-27 11:45:10 PST

Created attachment 43964 [details] initial status

Adam Barth

Comment 3 2009-11-27 11:51:07 PST

Created attachment 43965 [details] initial status

Eric Seidel (no email)

Comment 4 2009-11-27 15:27:22 PST

Comment on attachment 43965 [details] initial status .cached_scm was a name from a naiver time. :) I think we shoudl just call it ._scm now. I feel like PatchCollection hasn't quite figured out what it is yet. :( Part of me thinks we shoudl make somethign that works perfectly for hte style queue and worry about abstracting it later, since I had to rip PatchCollection out of commit-queue already. :( Looks OK though. I'd prefer we went with _scm and _statusbot though.

Adam Barth

Comment 5 2009-11-27 15:34:51 PST

Comment on attachment 43965 [details] initial status Clearing flags on attachment: 43965 Committed r51447: <http://trac.webkit.org/changeset/51447>

Adam Barth

Comment 6 2009-11-27 15:34:56 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.