Bug 31925

Summary:

Memory usage code in V8GCController lacks PLATFORM(CHROMIUM) guards

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Steve Block <steveblock>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

antonm, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch 1 for Bug 31925	eric: review+

Steve Block

Reported 2009-11-27 04:17:49 PST

Memory usage code in V8GCController lacks PLATFORM(CHROMIUM) guards. This code uses ChromiumBridge and Chromium-specific constant values.

Attachments
Patch 1 for Bug 31925 (1.91 KB, patch) 2009-11-27 04:26 PST, Steve Block	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2009-11-27 04:26:13 PST

Created attachment 43941 [details] Patch 1 for Bug 31925

Eric Seidel (no email)

Comment 2 2009-11-28 09:37:17 PST

Comment on attachment 43941 [details] Patch 1 for Bug 31925 I take it this is because Andriod is compiling with V8 now. The ChangeLog might want to mention that. :)

Steve Block

Comment 3 2009-11-30 02:35:54 PST

This was introduced in http://trac.webkit.org/changeset/50752

Steve Block

Comment 4 2009-11-30 02:43:21 PST

Committed as http://trac.webkit.org/changeset/51483

anton muhin

Comment 5 2009-11-30 09:18:23 PST

(In reply to comment #4) > Committed as http://trac.webkit.org/changeset/51483 Thanks and sorry for breaking it. How could I have checked it before submitting?

Steve Block

Comment 6 2009-11-30 09:23:34 PST

> Thanks and sorry for breaking it. No problem > How could I have checked it before submitting? You couldn't have. We're working as fast as we can to unfork the Android port and set up an Android buildbot!

Note You need to log in before you can comment on or make changes to this bug.