Bug 31898

Summary:

[Qt] Make QtLauncher default to http scheme

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, kenneth, zoltan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Description Daniel Bates 2009-11-25 19:35:01 PST

We should make the QtLauncher default to the http scheme for URLs so that it is more user friendly.

Comment 1 Daniel Bates 2009-11-25 19:37:56 PST

Created attachment 43889 [details]
Patch

Comment 2 Adam Barth 2009-11-30 12:41:59 PST

Attachment 43889 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/qt/QtLauncher/main.cpp:191:  Tab found; better to use spaces  [whitespace/tab] [1]
Done processing WebKit/qt/QtLauncher/main.cpp
Total errors found: 1

Comment 3 Daniel Bates 2009-11-30 13:53:51 PST

Created attachment 44040 [details]
Patch

Removed tab character from patch that the style-bot found.

Comment 4 Adam Barth 2009-11-30 13:57:38 PST

style-queue ran check-webkit-style on attachment 44040 [details] without any errors.

Comment 5 WebKit Commit Bot 2009-12-01 14:05:10 PST

Comment on attachment 44040 [details]
Patch

Clearing flags on attachment: 44040

Committed r51558: <http://trac.webkit.org/changeset/51558>

Comment 6 WebKit Commit Bot 2009-12-01 14:05:15 PST

All reviewed patches have been landed.  Closing bug.