Bug 31898

Summary: [Qt] Make QtLauncher default to http scheme
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, kenneth, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Daniel Bates
Reported 2009-11-25 19:35:01 PST
We should make the QtLauncher default to the http scheme for URLs so that it is more user friendly.
Attachments
Patch (2.14 KB, patch)
2009-11-25 19:37 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (2.16 KB, patch)
2009-11-30 13:53 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2009-11-25 19:37:56 PST
Created attachment 43889 [details] Patch
Adam Barth
Comment 2 2009-11-30 12:41:59 PST
Attachment 43889 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/qt/QtLauncher/main.cpp:191: Tab found; better to use spaces [whitespace/tab] [1] Done processing WebKit/qt/QtLauncher/main.cpp Total errors found: 1
Daniel Bates
Comment 3 2009-11-30 13:53:51 PST
Created attachment 44040 [details] Patch Removed tab character from patch that the style-bot found.
Adam Barth
Comment 4 2009-11-30 13:57:38 PST
style-queue ran check-webkit-style on attachment 44040 [details] without any errors.
WebKit Commit Bot
Comment 5 2009-12-01 14:05:10 PST
Comment on attachment 44040 [details] Patch Clearing flags on attachment: 44040 Committed r51558: <http://trac.webkit.org/changeset/51558>
WebKit Commit Bot
Comment 6 2009-12-01 14:05:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.