Bug 31895

Summary: Clean up V8 bindings for CSSStyleDeclaration and CSSVariableDeclaration
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: WebCore JavaScriptAssignee: Erik Arvidsson <arv>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Adds a setCollectionStringIndexedGetter and uses that instead of setCollectionStringOrNullIndexedGetter
none
Patch (with ChangeLog this time) none

Erik Arvidsson
Reported 2009-11-25 17:04:54 PST
These index getters never return a null string so to make things clearer do not use string-or-null index getter.
Attachments
Adds a setCollectionStringIndexedGetter and uses that instead of setCollectionStringOrNullIndexedGetter (3.66 KB, patch)
2009-11-25 17:15 PST, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Patch (with ChangeLog this time) (4.60 KB, patch)
2009-11-26 11:39 PST, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2009-11-25 17:15:09 PST
Created attachment 43880 [details] Adds a setCollectionStringIndexedGetter and uses that instead of setCollectionStringOrNullIndexedGetter
Erik Arvidsson
Comment 2 2009-11-26 11:39:34 PST
Created attachment 43929 [details] Patch (with ChangeLog this time)
Adam Barth
Comment 3 2009-11-26 23:45:06 PST
Comment on attachment 43929 [details] Patch (with ChangeLog this time) This looks reasonable. Do we really use uint32_t? I would have expected us to use unsigned.
Erik Arvidsson
Comment 4 2009-11-27 12:37:43 PST
uint32_t seems more correct to me since that is the requirement for array indeces in EcmaScript.
Adam Barth
Comment 5 2009-11-27 14:10:26 PST
I'll leave it up to your judgement. Do we use uint32_t in other places where we deal with array indicies?
WebKit Commit Bot
Comment 6 2009-11-30 10:59:44 PST
Comment on attachment 43929 [details] Patch (with ChangeLog this time) Clearing flags on attachment: 43929 Committed r51501: <http://trac.webkit.org/changeset/51501>
WebKit Commit Bot
Comment 7 2009-11-30 10:59:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.