Bug 31884

Summary:

[v8] Make accessing entered isolated world faster

Product:

WebKit

Reporter:

anton muhin <antonm>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
First take	abarth: review+, abarth: commit-queue-
Addressing tabs	none

Description anton muhin 2009-11-25 11:55:50 PST

Currently to get entered isolated world, we do hidden property lookup which is slow.  Let's use internal field instead.

Comment 1 anton muhin 2009-11-25 15:28:31 PST

Created attachment 43873 [details]
First take

Comment 2 Adam Barth 2009-11-25 18:22:57 PST

Comment on attachment 43873 [details]
First take

This looks great, but we'll need to lose the tabs.

Comment 3 anton muhin 2009-11-26 05:38:13 PST

Created attachment 43917 [details]
Addressing tabs

Comment 4 anton muhin 2009-11-26 05:39:25 PST

Comment on attachment 43917 [details]
Addressing tabs

I am attempting to commit-queue+ it as Adam already r+'ed, if it fails, even better---Adam will be able to have another pass.

Comment 5 Adam Barth 2009-11-26 07:48:21 PST

Comment on attachment 43917 [details]
Addressing tabs

cq patiently waits for an r+ before landing patches.  :)

Comment 6 anton muhin 2009-11-26 07:54:13 PST

(In reply to comment #5)
> (From update of attachment 43917 [details])
> cq patiently waits for an r+ before landing patches.  :)

No easy way in this life, alas :)

Thanks a lot, Adam.  And happy thanksgiving.

Comment 7 WebKit Commit Bot 2009-11-26 07:59:54 PST

Comment on attachment 43917 [details]
Addressing tabs

Clearing flags on attachment: 43917

Committed r51416: <http://trac.webkit.org/changeset/51416>

Comment 8 WebKit Commit Bot 2009-11-26 08:00:01 PST

All reviewed patches have been landed.  Closing bug.