Summary: | [Chromium] Unable to repost form data by hitting reload | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Fisher (:fishd, Google) <fishd> | ||||
Component: | Page Loading | Assignee: | Darin Fisher (:fishd, Google) <fishd> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Darin Fisher (:fishd, Google)
2009-11-25 10:39:16 PST
Created attachment 43863 [details] v1 patch I went about writing a test for this, but sadly it can't work in DRT or TestShell because neither loads error pages. As a result I have no way to simulate the steps from comment #0. Enabling error pages would interfere with existing tests. I could modify the layoutTestController to support an option that would enable error pages, but that seems like a much larger change that I'd rather defer to a separate patch. (I'd like to land this so I can backport it to the Chrome 4 branch.) Comment on attachment 43863 [details]
v1 patch
This sounds reasonable. Again, my confidence here is low. Thanks for explaining why this is hard to test.
+ m_frame->loader()->activeDocumentLoader()->originalRequestCopy();
I'd prefer grabbing this object via m_frame->loader()->originalRequest(); but that's not essential.
> I'd prefer grabbing this object via m_frame->loader()->originalRequest(); but
> that's not essential.
Oh, good call! Thanks, I'll do that.
Landed as http://trac.webkit.org/changeset/51394 |