Bug 31865

Summary:

Re-do ruby layout tests to use only Latin characters

Product:

WebKit

Reporter:

Roland Steiner <rolandsteiner>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, eric, hyatt, mitz, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch - re-do ruby layout tests	eric: review+
patch - base-lines for Windows	levin: review+, eric: commit-queue-

Roland Steiner

Reported 2009-11-25 01:59:33 PST

The current set of layout tests for ruby rendering in fast/ruby uses Japanese for the example sentences, since Japanese Furigana (reading annotations) are a main use case for <ruby>. However, this apparently causes problems on non-Mac platforms, as evidenced by feedback on the mailing list and the fact that most (all?) other layout tests that use non-Latin characters are listed in platform/win/Skipped (for the Windows platform). Since there is no fundamental reason to use Japanese characters for the ruby layout tests, re-doing them to use Latin characters seems prudent.

Attachments
patch - re-do ruby layout tests (691.50 KB, patch) 2009-11-25 02:01 PST, Roland Steiner	eric: review+	Details Formatted Diff Diff
patch - base-lines for Windows (655.75 KB, patch) 2009-12-16 20:04 PST, Roland Steiner	levin: review+ eric: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Roland Steiner

Comment 1 2009-11-25 02:01:31 PST

Created attachment 43832 [details] patch - re-do ruby layout tests New versions of the ruby layout tests that use English text rather than Japanese, includes the pixel test results for Mac.

Eric Seidel (no email)

Comment 2 2009-11-25 07:43:05 PST

I suspect that getting the right fonts on windows is probably a pain.

Eric Seidel (no email)

Comment 3 2009-11-25 07:44:53 PST

Comment on attachment 43832 [details] patch - re-do ruby layout tests Looks OK to me.

Roland Steiner

Comment 4 2009-12-02 19:31:36 PST

Note: still need to create Windows baselines before committing, in order to avoid having a mixed state with old and new result expectations (my Windows machine for that must arrive Real Soon Now... :p)

Eric Seidel (no email)

Comment 5 2009-12-14 14:07:05 PST

I see, so this bug is ready to land, just waiting on additional windows baselines from you? Thus I assume it cannot be commit-queue'd?

Roland Steiner

Comment 6 2009-12-14 18:04:53 PST

(In reply to comment #5) Yes - I received my XP machine yesterday, but I'm not sure I get to do the Windows baselines before my vacation.

Roland Steiner

Comment 7 2009-12-16 20:04:13 PST

Created attachment 45032 [details] patch - base-lines for Windows

WebKit Review Bot

Comment 8 2009-12-16 20:08:13 PST

style-queue ran check-webkit-style on attachment 45032 [details] without any errors.

Eric Seidel (no email)

Comment 9 2009-12-20 19:08:27 PST

So should these now be landed?

Roland Steiner

Comment 10 2009-12-21 02:22:10 PST

Yes, but I'm on vacation ATM, and have no easy source access. Could you perhaps land them for me? (Or I can also land them after I come back - these are hardly time-critical patches.)

Eric Seidel (no email)

Comment 11 2009-12-22 21:59:57 PST

Comment on attachment 45032 [details] patch - base-lines for Windows The tab in the ChangeLog will prevent this from being cq'd.

Eric Seidel (no email)

Comment 12 2010-01-14 13:00:34 PST

Ping? This bug has been in the pending-commit list a long time, and blocks bug 28420 which has been in the pending-commit list even longer. It's time to take action on these patches or mark them r-.

Roland Steiner

Comment 13 2010-01-14 20:45:28 PST

Committed as rev. 53316

Roland Steiner

Comment 14 2010-01-20 23:28:18 PST

First patch landed as rev. 53605 (was under the wrong impression that this had already landed before)

Note You need to log in before you can comment on or make changes to this bug.