Bug 31833

Summary: [Chromium] Fix DOM storage layout tests
Product: WebKit Reporter: Adam Barth <abarth>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, fishd, jorlow
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Adam Barth 2009-11-24 07:35:10 PST
Fix the dom storage layout tests broken by a recent patch:

LayoutTests/storage/domstorage/localstorage/index-get-and-set.html = TEXT
LayoutTests/storage/domstorage/localstorage/onstorage-attribute-markup.html
= TEXT
LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute.html
= TEXT
LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setwindow.html
= TEXT
LayoutTests/storage/domstorage/localstorage/simple-events.html = TEXT
LayoutTests/storage/domstorage/window-attributes-exist.html = TEXT
LayoutTests/storage/domstorage/localstorage/iframe-events.html = TIMEOUT
Comment 1 Adam Barth 2009-11-24 07:42:03 PST
Created attachment 43767 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2009-11-24 07:57:09 PST
Comment on attachment 43767 [details]
Patch

ok. Can you file a bug and give it to Jeremy on the "fix for realz"?
Comment 3 Adam Barth 2009-11-24 08:01:17 PST
Comment on attachment 43767 [details]
Patch

Will do.
Comment 4 WebKit Commit Bot 2009-11-24 08:16:02 PST
Comment on attachment 43767 [details]
Patch

Clearing flags on attachment: 43767

Committed r51338: <http://trac.webkit.org/changeset/51338>
Comment 5 WebKit Commit Bot 2009-11-24 08:16:08 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Adam Barth 2009-11-24 08:19:16 PST
Filed as https://bugs.webkit.org/show_bug.cgi?id=31835.