Bug 31830 – Chromium: Expose method for reporting user stats to the host.

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Pavel Feldman]

We'd like to push some stats from web inspector to the host.

[Pavel Feldman]

Created attachment 43766 [details]
[PATCH] 

Note that I should land it after implementation lands in Chromium.

[Adam Barth]

Comment on attachment 43766 [details]
[PATCH] 

Marking cq- so we don't accidentally commit this before the downstream change.

[Dimitri Glazkov (Google)]

Comment on attachment 43766 [details]
[PATCH] 

ok.

[Eric Seidel (no email)]

Comment on attachment 43766 [details]
[PATCH] 

Where is this ever used?  Why would we add this virtual function w/o it ever being used anywhere...  This change is not required before the downstream one since you can always add a virtual method which is never called.  In fact, this change would break the downstream version if checked in, so I'm not sure I understand why this is being added at all w/o ever being used.

I guess I don't understand the patch or the r+.

[Pavel Feldman]

> I guess I don't understand the patch or the r+.

http://codereview.chromium.org/435019/show

[Pavel Feldman]

Created attachment 43787 [details]
[PATCH] Darin suggests that it is exposed to whole WebKit.

[Darin Fisher (:fishd, Google)]

Comment on attachment 43787 [details]
[PATCH] Darin suggests that it is exposed to whole WebKit.

> +    // By default, histogram is exponential, so that min=1, max=1000000, bucketCound=50 would do. Setting

nit: s/bucketCound/bucketCount/

[Darin Fisher (:fishd, Google)]

if you add a default implementation, then you don't have to worry about a painful two sided landing

virtual void histogramCounts(...) { }

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/public/WebKitClient.h
Committed r51345

Landed with drive-by default implementations for the whole client itself.