Summary: | Allow custom memory allocation control for classes of the plugins and rendering directory in WebCore | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Zoltan Horvath
2009-11-24 05:26:13 PST
Comment on attachment 43761 [details]
Patch
I expect we're increasing the size of the WebCore binary by adding all these template instantiations. That said, this change looks right, and is useful for documenting the use of these classes. I'm still not sure I fully understand your quest to make new/delete replaceable, but this change is a good one.
> I'm still not sure I fully understand
> your quest to make new/delete replaceable, but this change is a good one.
Unfortunately, the global operator new technique doesn't work (on Linux and Windows). When you use the WebKit as a shared library for an application it will customizes the application's new/delete also. This can lead to weird problems. (e.g. crash) The FastAllocBase solution provides a safety way to customize new/delete through locally in the classes, not by the global way. So, we'll have full allocation control over the classes.
I'm going to land the patch now, thanks for the review. :)
Landed in 51378. http://trac.webkit.org/changeset/51378 |