Bug 31820

Summary:

[Chromium] Ignore line-height CSS property for search fields

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

Layout and Rendering

Assignee:

Kent Tamura <tkent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	none

Description Kent Tamura 2009-11-23 22:00:20 PST

http://crbug.com/20551

LayoutTests/fast/forms/control-restrict-line-height.html checks that the
following controls should ignore line-height CSS property, and Chromium/Windows
and Chromium/Linux don't ignore it for button and search.
 - <select>
 - <input type=button>
 - <input type=search>

This bug addresses the type=search case.

Comment 1 Kent Tamura 2009-11-23 23:04:43 PST

Created attachment 43750 [details]
Proposed patch

Chromium try logs:
Linux: http://build.chromium.org/buildbot/try-server/builders/layout_linux/builds/746
Windows: http://build.chromium.org/buildbot/try-server/builders/layout_win/builds/734

Comment 2 Eric Seidel (no email) 2009-11-24 10:00:25 PST

Comment on attachment 43750 [details]
Proposed patch

OK, looks sane.

Comment 3 WebKit Commit Bot 2009-11-24 18:16:45 PST

Comment on attachment 43750 [details]
Proposed patch

Clearing flags on attachment: 43750

Committed r51368: <http://trac.webkit.org/changeset/51368>

Comment 4 WebKit Commit Bot 2009-11-24 18:16:50 PST

All reviewed patches have been landed.  Closing bug.