Bug 31818

Summary: scm_unittest.py is too slow
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, evan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+

Description Eric Seidel (no email) 2009-11-23 20:16:03 PST
scm_unittest.py is too slow

If you run run-webkit-unittests -v you'll see that we spend basically all of our time running the unit tests running the scm usit tests.  This is because we create a new svn and git repository on every test and that's slow.  We should find a better way to opt-in to creating a new repository so that we can have faster overall testing.
Comment 1 Adam Barth 2009-12-15 00:27:18 PST
Created attachment 44851 [details]
Patch
Comment 2 WebKit Review Bot 2009-12-15 00:28:03 PST
style-queue ran check-webkit-style on attachment 44851 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-15 00:31:17 PST
Comment on attachment 44851 [details]
Patch

You might consider using .remove() instead.  Also needs a #HACK or #FIXME comment.
Comment 4 Adam Barth 2009-12-15 00:57:53 PST
Committed r52142: <http://trac.webkit.org/changeset/52142>