Summary: | [V8] Don't crash when OOM in creating isolated world | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ager, antonm, dglazkov | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Adam Barth
2009-11-23 07:26:59 PST
Created attachment 43715 [details]
Patch
(In reply to comment #1) > Created an attachment (id=43715) [details] > Patch I thought that we crash in this line: v8::Handle<v8::Value> windowContextData = m_context->GetData(); shouldn't we add if (m_context.IsEmpty()) check above as well? Created attachment 43717 [details]
Patch
Right you are! Comment on attachment 43717 [details]
Patch
Thanks a lot.
Comment on attachment 43717 [details]
Patch
Thanks Anton, but according to committers.py, you're not a reviewer (yet!). We still need an official reviewer to sign off on this patch.
Comment on attachment 43717 [details]
Patch
r=me.
Committed r51312: <http://trac.webkit.org/changeset/51312> |