Bug 31800
| Summary: | External function declarations (in JSC) are exported with gcc | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Hausmann <hausmann> |
| Component: | New Bugs | Assignee: | Simon Hausmann <hausmann> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | cmarcelo, laszlo.gombos |
| Priority: | P3 | Keywords: | Qt |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Other | ||
| OS: | OS X 10.5 | ||
Simon Hausmann
When WebKit is built with -fvisibility=hidden, but functions declared as extern are still exported. This is correct behaviour according to the gcc man-page.
I propose to replace the direct use of extern "C" with macros that when compiling with gcc include a leading #pragma GCC visibility push(hidden) and a #pragma GCC visibility pop when closing the extern declaration.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Hausmann
This should also allow us to get rid of the HIDE_SYMBOL macros in JITStubs.cpp
Jocelyn Turcotte
=== Bulk closing of Qt bugs ===
If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it.
If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.