Bug 31793

Summary:

Move GOwnPtr* from wtf to wtf/gtk

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hamaji, jmalonzo, xan.lopez, zecke

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
proposed patch	none
fix indentation in JavaScriptCore/GNUmakefile.am	none
Sorry, this was a wrong patch	none
chromium build fix	none

Laszlo Gombos

Reported 2009-11-22 20:16:49 PST

Since there is already a wtf/gtk directory and GOwnPtr* is only used by WebKitGTK+ port, seems like a logical step to move GOwnPtr* from wtf to wtf/gtk.

Attachments
proposed patch (19.78 KB, patch) 2009-11-22 20:24 PST, Laszlo Gombos	no flags	Details Formatted Diff Diff
fix indentation in JavaScriptCore/GNUmakefile.am (19.76 KB, patch) 2009-11-22 20:27 PST, Laszlo Gombos	no flags	Details Formatted Diff Diff
Sorry, this was a wrong patch (19.53 KB, patch) 2009-11-27 12:21 PST, Shinichiro Hamaji	no flags	Details Formatted Diff Diff
chromium build fix (1.23 KB, patch) 2009-11-27 12:23 PST, Shinichiro Hamaji	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Laszlo Gombos

Comment 1 2009-11-22 20:24:27 PST

Created attachment 43692 [details] proposed patch This patch has an impact at least on the following ports: gtk, wx, chromium. I'm happy to break out the patch into individual ports. I have not had a chance to test if this change does not break any of the ports mentioned above - particularly the gtk port. Even though the changes are trivial I think at very least WebKitGTK+ needs to be be built with the patch before review+/landing this change. If someone can help with that that would be great, otherwise I will try to find some time to do so.

Laszlo Gombos

Comment 2 2009-11-22 20:27:41 PST

Created attachment 43693 [details] fix indentation in JavaScriptCore/GNUmakefile.am

Oliver Hunt

Comment 3 2009-11-22 21:35:29 PST

Comment on attachment 43693 [details] fix indentation in JavaScriptCore/GNUmakefile.am r=me

Laszlo Gombos

Comment 4 2009-11-26 20:56:17 PST

Landed as http://trac.webkit.org/changeset/51423.

Shinichiro Hamaji

Comment 5 2009-11-27 12:21:25 PST

Created attachment 43966 [details] Sorry, this was a wrong patch

Shinichiro Hamaji

Comment 6 2009-11-27 12:23:24 PST

Created attachment 43967 [details] chromium build fix

Shinichiro Hamaji

Comment 7 2009-11-27 12:24:45 PST

This change makes chromium build fail. We need to ignore GOwnPtr. This patch ignores gtk directory.

Laszlo Gombos

Comment 8 2009-11-27 16:20:47 PST

(In reply to comment #7) > This change makes chromium build fail. We need to ignore GOwnPtr. This patch > ignores gtk directory. Thanks. I do not have review+ bit, but as this is a build fix and related to my change I think it is best to commit it (as it looks good to me). Committed as http://trac.webkit.org/changeset/51452.

Shinichiro Hamaji

Comment 9 2009-11-27 22:32:29 PST

Thanks for checking and landing my patch.

Note You need to log in before you can comment on or make changes to this bug.