Summary: | Web Inspector: Keyboard Shortcut to Clear Console Messages | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Joseph Pecoraro <joepeck> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2009-11-21 23:50:52 PST
Created attachment 43673 [details]
[PATCH] Cmd+K to Clear Console
Assigns ⌘K to Clear Console Messages for Mac Users.
> Any idea what this should be for Windows?
I don't think such a thing exists on Windows. Maybe Ctrl + K ?
While we are thinking about the shortcut... Should we make typing "clear" do the job? Currently you need to do "clear()" and it leaves "undefined" result as a trace. Not nice. I think a shortcut is fine. I don't think it can be Control-K on Windows, that might trigger the kill-to-end-of-line editing command (like it does on Mac). Created attachment 43678 [details] [PATCH] Cmd+K (Mac), Ctrl+L (Mac+Linux) to Clear Console It appears as though Ctrl+L means the same thing. This is likely to be a good thing for Linux users. Mac Users have this too (works in Terminal.app). Source: http://www.tuxfiles.org/linuxhelp/shortcuts.html Created attachment 43681 [details]
[PATCH] Cmd+K (Mac), Ctrl+L (All) to Clear Console
Chat on IRC sounded like Ctrl+L should be for all platforms. Don't single out Windows.
Comment on attachment 43681 [details]
[PATCH] Cmd+K (Mac), Ctrl+L (All) to Clear Console
I think we should somehow reuse what is in KeyboardShortcuts.js (or improve it or stop using it if it is not useful in all places). Overall, shortcuts framework is often useful.
Created attachment 43776 [details]
[PATCH] Cmd+K (Mac), Ctrl+L (All) to Clear Console Using KeyboardShortcut
Using the KeyboardShortcut lib
Comment on attachment 43776 [details] [PATCH] Cmd+K (Mac), Ctrl+L (All) to Clear Console Using KeyboardShortcut > + var shortcut; Move this lower? > + if (!this._shortcuts[shortcut].isMacOnly || WebInspector.isMac()) { We could make this logic a part of the makeKeyFromEvent, no? (In reply to comment #9) > (From update of attachment 43776 [details]) > > + var shortcut; > > Move this lower? Done. > > + if (!this._shortcuts[shortcut].isMacOnly || WebInspector.isMac()) { > > We could make this logic a part of the makeKeyFromEvent, no? Like you mentioned in IRC, this could move to a Modifier, or something like that. But we decided to leave it for now. Landed in http://trac.webkit.org/changeset/51341 r51341 = 8b54f6e271ac7bb77580c41b7b6ffd1d65c29cd8 |